Skip to content

Use SwiftLogNoOpLogHandler from swift-log instead of local version #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2020
Merged

Use SwiftLogNoOpLogHandler from swift-log instead of local version #282

merged 3 commits into from
Jul 17, 2020

Conversation

adam-fowler
Copy link
Member

No description provided.

@Lukasa
Copy link
Collaborator

Lukasa commented Jul 16, 2020

The biggest issue right now is that the master branch seems not to build due to warnings as errors. We'll need to update it to fix this build problem, one sec.

artemredkin
artemredkin approved these changes Jul 16, 2020
View reviewed changes
Copy link
Collaborator

@artemredkin artemredkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @adam-fowler

@Lukasa Lukasa added the 🔨 semver/patch No public API change. label Jul 17, 2020
@Lukasa Lukasa merged commit 96a803e into swift-server:master Jul 17, 2020
@adam-fowler adam-fowler deleted the swift-log-noop branch July 17, 2020 08:48
@ktoso
Copy link
Contributor

ktoso commented Jul 17, 2020

Thanks, Adam :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemredkin artemredkin artemredkin approved these changes

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adam-fowler @Lukasa @ktoso @artemredkin